Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guard parameter to can() #2526

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Add guard parameter to can() #2526

merged 2 commits into from
Oct 25, 2023

Conversation

drbyte
Copy link
Collaborator

@drbyte drbyte commented Oct 24, 2023

As discussed in comments in: #2515 (comment)

drbyte and others added 2 commits October 24, 2023 01:40
@drbyte @parallels999
Add guard parameter to can()
a9d0f48 
As discussed in comments on 2515: #2515 (comment)

Co-authored-by: parallels999 <parallels999@users.noreply.github.com>
@drbyte @github-actions
Fix styling
760f3bc
@drbyte
Copy link
Collaborator Author

drbyte commented Oct 24, 2023

NOTE: Undecided whether this is actually safe, or whether it will break when can() is used with additional parameters such as Model names or Model instances.

@drbyte drbyte merged commit 239abc5 into main Oct 25, 2023
22 checks passed
@drbyte drbyte deleted the add-guard-to-can-directive branch October 25, 2023 04:55
@erikn69
Copy link
Contributor

erikn69 commented Oct 25, 2023

Seems like a good feature, hopefully it doesn't break any custom implementations 👍

@parallels999 parallels999 mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted needs more information
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drbyte @erikn69