Add middleware using static method #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parallels999
reviewed
May 3, 2023
|
Also add usage info in docs |
jnoordsij
force-pushed
the
add-middleware-using-static-method
branch
from
594c409 to
6d64d6f
Compare
|
@parallels999 thanks for checking this! Added some bits to the docs to explain the new methods. |
parallels999
reviewed
May 4, 2023
|
I like the idea. Will review it in more detail soon... |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the addition of static
usingmethods in the Laravel framework itself that allow creating middlewares with arguments in a static way (see laravel/framework#46362), this PR aims to add similar behavior to the middlewares in this package.This allows a new syntax for adding the middlewares to routes and/or controllers, e.g. instead of
'permission:edit-articles|edit-news', one can now writePermissionMiddleware::using('edit-articles|edit-news')or evenPermissionMiddleware::using(['edit-articles', 'edit-news']).