refactor: Change static properties to non-static #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivernybroe
force-pushed
the
lazy-binding-fix
branch
from
7574fba to
20cd940
Compare
|
What about call config helper instead of app?? olivernybroe#1 |
Use config helper on migrations
|
@erikn69 good idea, prob. more stable in long term, but won't solve that it's a breaking change 👍 |
yes, unfortunately |
|
Thanks guys. |
drbyte
added a commit
that referenced
this pull request
Feb 13, 2023
Fix tests after #2324 refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the static properties on
PermissionRegistrarnon-static.This will make sure that if any of the properties are accessed, the cache initialization has happened first.
BREAKING CHANGE:
This is a breaking change as it will make all current migration files fail, as they are currently accessing the static properties which are not static anymore.