Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Role::withCount if belongsToMany declared #2280

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Fix Role::withCount if belongsToMany declared #2280

merged 2 commits into from
Feb 8, 2023

Conversation

xenaio-daniil
Copy link
Contributor

fixes #2277

@xenaio-daniil
Fix Role::withCount if belongsToMany declared
7e801e2 
fixes spatie#2277
@xenaio-daniil
Fixed RoleWithNestingTest
222762f 
Fixed RoleWithNestingTest as it expected integer from withCount, but string provided by older version's of framework
@drbyte drbyte merged commit b881a07 into spatie:main Feb 8, 2023
@drbyte
Copy link
Collaborator

drbyte commented Feb 8, 2023

Thanks.

@erikn69 erikn69 mentioned this pull request Mar 20, 2023
Merged
@drbyte drbyte mentioned this pull request Apr 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YasinAshorian YasinAshorian YasinAshorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Role::getTable() method brokes withCount method
3 participants
@xenaio-daniil @drbyte @YasinAshorian