Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete all Blade directives via Laravel Idea plugin #2210

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

maartenpaauw
Copy link
Contributor

No description provided.

@drbyte
Copy link
Collaborator

drbyte commented Oct 13, 2022

Hi @maartenpaauw Thanks for this.

Will this same proposal work okay if #2168 gets merged? Or will there be complications for implementing this?

@maartenpaauw
Copy link
Contributor Author

Hi @drbyte, if #2168 gets merged I've to change all the prefix and suffix values so it will use the same code. Can you ping me when it gets merged? Then I'll rebase my branch and fix the code.

@erikn69
Copy link
Contributor

erikn69 commented Oct 14, 2022

is there a better alternative for #2168?

@maartenpaauw
Copy link
Contributor Author

@erikn69 I think your PR is a great feature addition. My PR has nothing to do how to blade directives work. It's just adding auto-completion for PHPStorm via the plugin Laravel Idea.

@drbyte
Copy link
Collaborator

drbyte commented Oct 19, 2022

@maartenpaauw #2168 has been merged.

@maartenpaauw
Copy link
Contributor Author

@drbyte great! I'll rebase my branch later this week.

@maartenpaauw maartenpaauw force-pushed the feature/laravel-idea-directives branch from d9926a1 to 8943ac1 Compare October 22, 2022 09:18
@maartenpaauw maartenpaauw force-pushed the feature/laravel-idea-directives branch from 8943ac1 to cdf7302 Compare October 22, 2022 09:19
@maartenpaauw
Copy link
Contributor Author

@drbyte I've rebased the branch and updated the auto complete directives.

@drbyte
Copy link
Collaborator

drbyte commented Oct 23, 2022

Thanks!

@drbyte drbyte merged commit dbd3d46 into spatie:main Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants