Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain using package with laravel's authorize method #1122

Merged
merged 2 commits into from
Jul 1, 2019

Conversation

cbernard73
Copy link
Contributor

There's not much in the documentation about using the package from within a Controller. I've added a paragraph to address that area.

@drbyte
Copy link
Collaborator

drbyte commented Jun 30, 2019

Hi,
With your edits, are you simply trying to say "if your user has a permission named the same as the policy method (ie: "show" in this case), then that permission will take precedence, and the policy won't trigger"?

@cbernard73
Copy link
Contributor Author

cbernard73 commented Jul 1, 2019 via email

Simplified the explanation of policy method name clash risks
@drbyte
Copy link
Collaborator

drbyte commented Jul 1, 2019

Cool. Thanks for submitting this.
I've simplified the description a little to make it more concise.

@drbyte drbyte merged commit b7e9d2e into spatie:master Jul 1, 2019
drbyte added a commit to killjin/laravel-permission that referenced this pull request Mar 21, 2024
drbyte added a commit that referenced this pull request Mar 21, 2024
* Revert #1122

---------

Co-authored-by: Chris Brown <code@drbyte.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants