Fix for publishing view files that has its custom namespace #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using namespaces, published view ignores namespaces and use its package name for vendor-view's directory name
freekmurze
requested changes
Oct 10, 2022
askdkc
commented
Oct 10, 2022
There was a problem hiding this comment.
@freekmurze OK. I just avoid if-else statement and also added test for this
|
Thanks! |
This was referenced Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When your package view uses custom namespace, published view ignores the namespace and keeps using its package name for vendor-view's directory name.
For example, imagine you create a package that has some sort of image gallery. And you choose 'laravel-images' for your package view's namespace.
Now someone downloaded your package then decided to customize the views. So the person ran
php artisan vendor:publishcommand to publish the views from this package.But according to this sources
laravel-package-toolsuses package name for its base_path and namespace and ignoring actual view namespace which the package creator specified.So no matter how the user modifies the published views, Laravel couldn't find the published view files.
This PR provides a fix for this problem.