implement enum based statuses #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
requested changes
Apr 22, 2024
|
Thanks! |
|
Wouldn't this be considered a major change (tagging wise)? These changes are much appreciated, yet they completely change the way we interact with the package. Thank you! 🙏🏻 |
|
You should still be able to use strings like you used to, I believe. |
|
It seems I was wrong: string based statuses don't seem to work anymore. I've made a new release that reverts the changes of this PR. @alhelwany if you're up for it, create a new PR with your changes, while ensure all current functionality keeps working. Thanks! |
|
The solution I had in mind and implemented is definately a breaking change. I thought that the new release would be v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
worked on issue #118