Add ability to ignore transition to same state #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me-state Feature/ignore transition to same state
…me-state Add ability to ignore transition to same state
|
Sorry, can't find where to squash commits |
|
Yess, please merge and tag this!! |
freekmurze
reviewed
Dec 9, 2024
|
@Briareos17 Are you able to add the test as @freekmurze mentioned? We also really need this! :) |
|
Handled in #270 |
|
@zayedadel Thank you a lot for help with this |
|
@Briareos17 you're welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it is convenient not to get an error when you try to perform a transition to the same state, for example, when the state comes from the API and you do not know in advance what it is, so as not to manually register such cases through allowTransition, I added the ability to ignore such transitions