fix: move string check/decode for data in payload

[jryd]

Back towards the end of last year, we reported an issue we were having with the JobRecorder to Flare support. We were experiencing an issue where it seemed that the data payload in our jobs were a string rather than an array.

At the time, this fix was applied to help us with that.

Whilst it seemed to fix the issue at the time, we've seen this issue return:

Cannot access offset of type string on string {"exception":"[object] (TypeError(code: 0): Cannot access offset of type string on string at /home/app/vendor/spatie/laravel-ignition/src/Recorders/JobRecorder/JobRecorder.php:91)

The fix that was applied was inside the foreach loop and would only apply when there was a key in the payload that wasn't being ignored. Evidently, there are times when the payload does not contain any additional keys and so the fix is never applied.

I believe it would make more sense for this to exist outside of the foreach loop so that its always applied whenever the $payload['data'] is a string.

[freekmurze]

It seems the tests are failing due to the changes in this PR. Could you take a look?

[jryd]

Ah, sorry about that!

I've fixed the failing test, it was related to a test for unserializeable payloads.

I tinkered with a couple of different ways to resolve this and settled for a wrapping the if statement in a try/catch, like we've done in other places (which I presume is to handle the unserializeable payloads, amongst other things).

[freekmurze]

Thanks!