Prepend the connection onto the name #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some code to add the connection to the snapshot name if it's passed in
|
Could you add a tests to prove that this works and also update the readme? |
freekmurze
requested changes
Aug 31, 2024
src/Commands/Create.php
Outdated
| @@ -21,7 +21,11 @@ public function handle() | |||
| ?: config('db-snapshots.default_connection') | |||
| ?? config('database.default'); | |||
|
|
|||
| $snapshotName = $this->argument('name') ?? Carbon::now()->format('Y-m-d_H-i-s'); | |||
| if (! is_null($this->option('connection')) && is_null($this->argument('name'))) { | |||
There was a problem hiding this comment.
Could you refactor this to avoid using. else. Maybe put this logic in a dedicated function with early returns.
There was a problem hiding this comment.
Extracted to a private method
# Conflicts: # src/Commands/Create.php
|
@freekmurze test added, connection name extracted to a method, readme updated |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you don't pass a name, but DO pass a connection, this will prepend the connection onto the name. Example output below