Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null for fieldContext within resolvePotentialPartialArray #693

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

faustbrian
Copy link
Contributor

When resolvePropertyValue calls resolvePotentialPartialArray there is an exception thrown if $fieldContext is null. This is possible because the parameters of resolvePropertyValue contain ?TransformationContext $fieldContext which means it can be null but wasn't allowed to be null within resolvePotentialPartialArray.

This fixes that and was tested by making our own test suite pass again and errors going away when using our application.

@rubenvanassche
Copy link
Member

Thanks!

@rubenvanassche rubenvanassche merged commit 01c25c3 into spatie:main Mar 12, 2024
12 checks passed
@faustbrian faustbrian deleted the patch-1 branch March 12, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants