Add missing constructor parameters to error message #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was on the verge of PRing this. This would be very welcome, and I even suggest swapping "parameters given" and "parameters missing" so the latter becomes first. We could go as far as removing "parameters given" maybe. |
|
Thanks! |
Yes I think changing the order would be even better. But I would not remove "parameters given" since it already helped me sometimes, when I forgot to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only the given parameters are displayed when failing to create a data object. But if a Data Object has a lot of parameters it is hard to find the missing property.
This PR suggests displaying the missing constructor property names as well in the error message.