Conflict Between Optional and Required Rules

[clementbirkle]

✏️ Describe the bug
Optional should be skipped when a Required rule is applied (e.g., RequireWith, RequiredIf).

↪️ To Reproduce

it('this test should create an error during validation', function () {

    class UpdateProductData extends Data
    {
        public function __construct(
            #[RequiredWith('discountValue')]
            public DiscountType $discountType = new Optional,
            #[RequiredWith('discountType')]
            public float $discountValue = new Optional,
        ) {
        }
    }

    dd(UpdateProductData::validateAndCreate(['discountValue' => 20));
});

✅ Expected behavior
In this test, I expect an error message like 'The discountType is required when discountValue is present.', because discountValue is provided but discountType is not.

The issue arises due to two points:

1. If a value is not provided for an optional type, the rule will be removed. This should not happen if the attribute has rules like RequiredWith, RequiredIf, etc.
2. The SometimesRuleInferrer should not add the sometimes rule when the attribute has rules like RequiredWith, RequiredIf, etc.

🖥️ Versions

Laravel: 11
Laravel Data: 4.8.1
PHP: 8.2

I can try to make a PR if you think this is an issue.

[rubenvanassche]

This should be fixed with the release later today

[clementbirkle]

Thank you, @rubenvanassche, but this doesn't fully solve the problem for me.

For example:

it('this test should not create an error during validation', function () {

    class UpdateProductData extends Data
    {
        public function __construct(
            #[RequiredWith('discountValue')]
            public DiscountType $discountType = new Optional,
            #[RequiredWith('discountType')]
            public float $discountValue = new Optional,
        ) {
        }
    }

    dd(UpdateProductData::validateAndCreate([]));
});

This code currently throws an error, but it shouldn't, because neither discountType nor discountValue are provided. In this case, the Sometime rule shouldn't be removed.

[rubenvanassche]

I cannot reproduce that, you know you're missing the optional type in the properties?

[clementbirkle]

Sorry @rubenvanassche, my example was wrong!

Here is a correct example:

it('this test should not create an error during validation', function () {

    class UpdateProductData extends Data
    {
        public function __construct(
            public string|Optional $type = new Optional,
            #[RequiredUnless('type', 'bundle')]
            public float|null|Optional $price = new Optional,
        ) {
        }
    }

    UpdateProductData::validateAndCreate([]);
});

This code currently throws an error, but it shouldn't, because neither type nor price are provided. In this case, the Sometime rule shouldn't be removed.