Return empty response for 204 preflight requests

spatie · Jul 19, 2019 · 446391b · 446391b
1 parent 7d4e3b7
commit 446391b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/Cors.php b/src/Cors.php
@@ -63,7 +63,7 @@ protected function handlePreflightRequest()
             return $this->forbiddenResponse();
         }
 
-        return $this->corsProfile->addPreflightHeaders(response('Preflight OK', 204));
+        return $this->corsProfile->addPreflightHeaders(response(null, 204));
     }
 
     protected function forbiddenResponse()

diff --git a/tests/PreflightTest.php b/tests/PreflightTest.php
@@ -5,16 +5,17 @@
 class PreflightTest extends TestCase
 {
     /** @test */
-    public function it_responds_with_a_200_for_a_valid_preflight_request()
+    public function it_responds_with_a_204_for_a_valid_preflight_request()
     {
         $response = $this
             ->sendPreflightRequest('DELETE', 'https://spatie.be')
-            ->assertSuccessful()
-            ->assertSee('Preflight OK')
+            ->assertStatus(204)
             ->assertHeader('Access-Control-Allow-Methods', 'POST, GET, OPTIONS, PUT, PATCH, DELETE')
             ->assertHeader('Access-Control-Allow-Headers', 'Content-Type, X-Auth-Token, Origin, Authorization')
             ->assertHeader('Access-Control-Allow-Origin', '*')
             ->assertHeader('Access-Control-Max-Age', 60 * 60 * 24);
+
+        $this->assertEmpty($response->content());
     }
 
     /** @test */
@@ -53,7 +54,7 @@ public function it_responds_with_correct_header_for_a_preflight_request_when_all
     }
 
     /** @test */
-    public function it_responds_with_a_200_for_a_preflight_request_coming_from_an_allowed_origin()
+    public function it_responds_with_a_204_for_a_preflight_request_coming_from_an_allowed_origin()
     {
         config()->set('cors.default_profile.allow_origins', ['https://spatie.be']);