Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix performance issue around global vs model log disabling #682

Merged
merged 2 commits into from
Mar 10, 2020
Merged

fix performance issue around global vs model log disabling #682

merged 2 commits into from
Mar 10, 2020

Conversation

ragingdave
Copy link
Contributor

fixes #650

also adds in testbench as well to enable running tests outside of an app specifically

@Gummibeer Gummibeer merged commit 4aa4e7d into spatie:master Mar 10, 2020
@Gummibeer
Copy link
Collaborator

Thanks for this! :)
it's merged and released as https://github.com/spatie/laravel-activitylog/releases/tag/3.11.3

@ragingdave ragingdave deleted the disabled-perf-fix branch March 12, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gummibeer Gummibeer Gummibeer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance difference using model vs global enable/disable logging
2 participants
@ragingdave @Gummibeer