Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a default value to getExtraProperty #1090

Merged
merged 6 commits into from
Sep 22, 2022
Merged

Add a default value to getExtraProperty #1090

merged 6 commits into from
Sep 22, 2022

Conversation

grantholle
Copy link
Contributor

This adds the ergonomic ability to set a default value for getExtraProperty when the key doesn't exist on properties.

Gummibeer
Gummibeer approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@Gummibeer Gummibeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - thanks! 🎉

@Gummibeer
Copy link
Collaborator

Could you rebase on current main branch - there was a composer plugin missing so workflows can't run.

@grantholle
Copy link
Contributor Author

Should be good now 👍

@Gummibeer Gummibeer merged commit f9487d7 into spatie:main Sep 22, 2022
@Gummibeer
Copy link
Collaborator

https://github.com/spatie/laravel-activitylog/releases/tag/4.6.0

@grantholle grantholle deleted the default-property-value branch October 4, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gummibeer Gummibeer Gummibeer approved these changes

Assignees

@grantholle grantholle

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grantholle @Gummibeer