Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add indonesia holiday #66

Merged
merged 8 commits into from
Jan 30, 2024
Merged

Conversation

ddouble-d
Copy link
Contributor

Copy link
Member

@Nielsvanpach Nielsvanpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you sync your fork with this repo and rebase your branch on our main branch? That way I can run the tests here.

Also, aren't there any official Islamic public holidays in Indonesia?

src/Countries/Indonesia.php Outdated Show resolved Hide resolved
@ddouble-d
Copy link
Contributor Author

ddouble-d commented Jan 21, 2024

Thanks! Could you sync your fork with this repo and rebase your branch on our main branch? That way I can run the tests here.

Sure

Also, aren't there any official Islamic public holidays in Indonesia?

Actually there is, but need to add some method/trait that can be used also for other countries.
For example islamic calendar will be used also for malaysia / other islamic countries.

There's also holidays based on chinese, hindu, and buddha calendar

@Nielsvanpach
Copy link
Member

Is the Chinese Calendar used in Indonesia for public holidays? Chinese New Year for example?
https://github.com/spatie/holidays/blob/main/src/Calendars/ChineseCalendar.php

@ddouble-d
Copy link
Contributor Author

Is the Chinese Calendar used in Indonesia for public holidays? Chinese New Year for example? https://github.com/spatie/holidays/blob/main/src/Calendars/ChineseCalendar.php

yep, updated the pr

Copy link
Member

@Nielsvanpach Nielsvanpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tests/Countries/IndonesiaTest.php Outdated Show resolved Hide resolved
@Nielsvanpach Nielsvanpach merged commit 3635851 into spatie:main Jan 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants