Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(holiday): Utamaduni day renamed to Mazingira day #245

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

vamuigua
Copy link
Contributor

@vamuigua vamuigua commented Oct 10, 2024

  • This PR adds the logic required to dynamically calculate the name of the October 10th holiday in Kenya based on the year, reflecting changes from:

  • Align holiday names with Public Holidays Act (Kenya)

  • Utamaduni day, public holiday on October 10 was renamed Mazingira day, after the President assented the Statue Law Bill 2024.

@Nielsvanpach
Copy link
Member

Thanks!
So the name should still be Utamaduni before 2024? Could you update this PR so that's still the case?

@vamuigua
Copy link
Contributor Author

Yes. Let me update the PR to reflect that.

- Introduced logic to dynamically calculate the name of the October 10th holiday based on the year:
  - Mazingira Day for 2024 and beyond
  - Utamaduni Day from 2022-2023
  - Huduma Day from 2019-2021
  - Moi Day for 2018 and earlier

- Updated test cases to validate holiday names across different years.
@vamuigua
Copy link
Contributor Author

PR has been updated to reflect the changing of the names on October 10 in Kenya.

@Nielsvanpach
Copy link
Member

Great, thanks!

@Nielsvanpach Nielsvanpach merged commit ad8abf9 into spatie:main Oct 10, 2024
14 checks passed
@vamuigua vamuigua changed the title update(holiday): Utamaduni day renamed to Mazingira day feat(holiday): Add dynamic holiday naming for October 10th in Kenya Oct 10, 2024
@vamuigua vamuigua changed the title feat(holiday): Add dynamic holiday naming for October 10th in Kenya update(holiday): Utamaduni day renamed to Mazingira day Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants