Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bangladesh holidays #21

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

arifszn
Copy link
Contributor

@arifszn arifszn commented Jan 17, 2024

No description provided.

Copy link

@nhrrob nhrrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left feedback for minor changes.

Copy link

@nhrrob nhrrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Muhammad-Sarfaraz
Copy link

Hey there! Noticed most of holiday names are in their mother tongue – how about a sprinkle of Bengali magic to celebrate diversity?
https://github.com/spatie/holidays/blob/main/src/Countries/Belgium.php
https://github.com/spatie/holidays/blob/main/src/Countries/Brazil.php
https://github.com/spatie/holidays/blob/main/src/Countries/Hungary.php

'শহীদ দিবস' => '02-21', 'মুজিব জয়ন' => '03-17', 'Genocide Remembrance Day' => '03-25', 'স্বাধীনতা দিবস' => '03-26', 'ঈদুল ফিতর' => '04-10', 'পহেলা বৈশাখ' => '04-14', 'মে দিবস' => '05-01', 'বুদ্ধ পূর্ণিমা' => '05-19', 'ঈদুল আযহা' => '06-16', 'আশুরা' => '07-16', 'জাতীয় শোক দিবস' => '08-15', 'জন্মাষ্টমী' => '08-24', 'ঈদে মিলাদুন্নবী' => '09-15', 'দুর্গা পূজা' => '10-08', 'Armed Forces Day' => '11-21', 'Martyred Intellectuals Day' => '12-14', 'বিজয় দিবস' => '12-16', 'বড়দিন' => '12-25',

@nhrrob
Copy link

nhrrob commented Jan 18, 2024

Dont think bangla would be a good choice here.
Also naming should match official or govt names. Ex 21 Feb.

Only fixed dates are added here.
So we cant add Eid holidays.

@Muhammad-Sarfaraz
Copy link

Dont think bangla would be a good choice here. Also naming should match official or govt names. Ex 21 Feb.

Only fixed dates are added here. So we cant add Eid holidays.

Got it!

@Nielsvanpach
Copy link
Member

Thanks!

@Nielsvanpach Nielsvanpach merged commit 46fc7f3 into spatie:main Jan 19, 2024
1 check passed
ssmusoke pushed a commit to ssmusoke/holidays that referenced this pull request Jan 20, 2024
Co-authored-by: Ariful Alam <ariful.dev@miaki.com.bd>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants