Add New Zealand Holidays #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $holidays = Holidays::for(country: 'nz')->get(); | ||
|
|
||
| expect($holidays)->toBeArray()->not()->toBeEmpty(); | ||
| expect(formatDates($holidays))->toMatchSnapshot(); |
There was a problem hiding this comment.
Instead of a complete snapshot test, it might be more interesting to only test the specific case (it has a substitute day for new year)
| $holidays = Holidays::for(country: 'nz')->get(); | ||
|
|
||
| expect($holidays)->toBeArray()->not()->toBeEmpty(); | ||
| expect(formatDates($holidays))->toMatchSnapshot(); |
There was a problem hiding this comment.
Instead of a complete snapshot test, it might be more interesting to only test the specific case
There was a problem hiding this comment.
I took guidance from WalesTest.php as I wasn't quite sure what coverage would be appropriate.
There was a problem hiding this comment.
That test had been better with specific assertions too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding New Zealand holidays. Took guidance from Australia and Wales.