Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add panama holidays #147

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

amitsamtani
Copy link
Contributor

This Pull Request introduces support for the Panamanian holidays.

This is a duplicate pull request for the country Panama. Original PR.

This version of the PR adds support for:

  • Carnival Holidays
  • Bridge Days (also known as "puentes") in Panama. If a holiday falls on a Sunday, they give the following Monday off

@amitsamtani amitsamtani mentioned this pull request Jan 20, 2024
@Nielsvanpach
Copy link
Member

Thanks! Did you verify the results generated in the snapshot file?

@amitsamtani
Copy link
Contributor Author

Hi Niels, yes. I reviewed the results in the generated snapshot file and the holidays appear in order along with the bridged holidays we have in our country.

@Nielsvanpach
Copy link
Member

Thanks! PR looks good, I'll wait on some approvals by others before merging.

@freekmurze freekmurze merged commit 37852fc into spatie:main Jan 23, 2024
8 checks passed
@amitsamtani amitsamtani deleted the feature/add-panama-holidays branch January 24, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants