Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Benin Holidays #145

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Add Benin Holidays #145

merged 3 commits into from
Jun 13, 2024

Conversation

Massoud114
Copy link
Contributor

Contributing a new country ?

  • Yes, I've checked, and there is no current PR for Benin. I had already opened one and it was closed.
  1. Create a new class in the Countries directory. It should extend the Country class.
  2. Add a test for the new country in the tests directory.
  3. Run the tests so a snapshot gets created.
  4. Verify the result in the newly created snapshot is correct.

This was referenced Jan 20, 2024
composer.json Outdated Show resolved Hide resolved
src/Countries/Benin.php Outdated Show resolved Hide resolved
@@ -0,0 +1,54 @@
[
{
"name": "F\u00eate du Ramadan",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results seem to be wrong? Have you checked all results in the snapshot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of the snapshot is badly encoded for French characters (é,è,ê...), I don't know how to fix it.

tests/Countries/BeninTest.php Outdated Show resolved Hide resolved
@Nielsvanpach Nielsvanpach merged commit ba2b3d6 into spatie:main Jun 13, 2024
14 checks passed
@Nielsvanpach
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants