Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 6.0 Shift #52

Merged
merged 6 commits into from
Sep 4, 2019
Merged

Laravel 6.0 Shift #52

merged 6 commits into from
Sep 4, 2019

Conversation

freekmurze
Copy link
Member

This pull request includes the changes for upgrading to Laravel 6.0. Feel free to commit any additional changes to the shift-17756 branch.

Before merging, you should:

  • Checkout the shift-17756 branch
  • Review all pull request comments for additional changes
  • Update your dependencies for Laravel 6.0
  • Run composer update (if the scripts fail, add --no-scripts)
  • Thoroughly test your application (no tests?)

If you want help with your upgrade, check out the Shift Human Services or join the Shifty Coders Slack room to get answers to all your Laravel questions.

The Laravel framework adopts the PSR-2 coding style with some additions.
Laravel apps *should* adopt this coding style as well.

However, Shift allows you to customize the adopted coding style through
the [.shiftrc][1] file by using your [PHP CS Fixer][2] config.

[1]: https://laravelshift.com/shiftrc-configuration-file
[2]: https://github.com/FriendsOfPHP/PHP-CS-Fixer
In an effort to make upgrading the constantly changing config files
easier, Shift defaulted them so you can review the commit diff for
changes. Moving forward, you should use ENV variables or create a
separate config file to allow the core config files to remain
automatically upgradeable.
@freekmurze
Copy link
Member Author

freekmurze commented Sep 4, 2019

⚠️ Shift defaulted the following configuration files. This was done in the Default config files commit so you may easily review and backfill any of your customizations.

  • config/services.php

@freekmurze
Copy link
Member Author

❌ Laravel 6.0 has a dependency for php of ^7.2. You have a modified dependency for php in your composer.json. You should review your dependency and ensure it meets the new version requirement.

@freekmurze
Copy link
Member Author

❌ Laravel 6.0 has a development dependency for phpunit/phpunit of ^8.0. You have a modified dependency for phpunit/phpunit in your composer.json. You should review your dependency and ensure it meets the new version requirement.

@freekmurze
Copy link
Member Author

ℹ️ Laravel 6.0 made performance optimizations for integer key types. If you are using a string as your model's primary key, you may set the $keyType property on your model.

/**
 * The "type" of the primary key ID.
 *
 * @var string
 */
protected $keyType = 'string';

@freekmurze
Copy link
Member Author

ℹ️ The mandrill and sparkpost mail drivers, as well as the rackspace storage driver were removed in Laravel 6.0. If you were using these drivers, you may adopt a community maintained package which provides the driver.

@freekmurze
Copy link
Member Author

ℹ️ Previous versions of Laravel would retry jobs indefinitely. Beginning with Laravel 6.0, the php artisan queue:work now tries a job one time by default. If you want to force jobs to be tried indefinitely, you may pass the --tries=0 option.

@freekmurze
Copy link
Member Author

⚗️ This Shift is still being refined. Please report any issues or suggestions. Your feedback is what helps improve the experience for everyone.

@freekmurze
Copy link
Member Author

🎉 Congratulations, you're now running the latest version of Laravel.

The following Shifts can ensure your app is fully upgraded and following the practices recommended by Laravel and the community:

  • Laravel Linter analyzes your codebase for potential opportunities to do things "The Laravel Way".
  • Laravel Fixer automates many of the suggestions found by the Linter and other Shifts.
  • Upgrade Checker ensures your application is fully upgraded by detecting any outdated code.

In addition, stay upgraded forever as well as run these Shifts by subscribing to one of the new Shifty Plans.

@freekmurze freekmurze merged commit 6b0141e into master Sep 4, 2019
@freekmurze freekmurze deleted the shift-17756 branch September 4, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants