-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 6.0 Shift #151
Laravel 6.0 Shift #151
Conversation
In an effort to make upgrading the constantly changing config files easier, Shift defaulted them so you can review the commit diff for changes. Moving forward, you should use ENV variables or create a separate config file to allow the core config files to remain automatically upgradeable.
|
ℹ️ The Eloquent model's |
ℹ️ Laravel 6.0 made performance optimizations for integer key types. If you are using a string as your model's primary key, you may set the /**
* The "type" of the primary key ID.
*
* @var string
*/
protected $keyType = 'string'; |
ℹ️ The |
ℹ️ Previous versions of Laravel would retry jobs indefinitely. Beginning with Laravel 6.0, the |
ℹ️ Shift noticed you have additional namespaces in your application. You should consider using the Consolidate Namespaces Shift to simplify your namespaces into the default Laravel |
⚗️ This Shift is still being refined. Please report any issues or suggestions. Your feedback is what helps improve the experience for everyone. |
🎉 Congratulations, you're now running the latest version of Laravel. The following Shifts can ensure your app is fully upgraded and following the practices recommended by Laravel and the community:
In addition, stay upgraded forever as well as run these Shifts by subscribing to one of the new Shifty Plans. |
app/Http/Kernel.php
Outdated
@@ -39,6 +39,7 @@ class Kernel extends HttpKernel | |||
*/ | |||
protected $routeMiddleware = [ | |||
'auth' => \App\Http\Middleware\Authenticate::class, | |||
\Illuminate\Routing\Middleware\ThrottleRequests::class, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the 'throttle'
key is missing 👀 @jasonmccreary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not exactly it, it actually belongs in the middleware priority. That's where it should have been added. I'll tweak the hooks to ensure it skips this part.
This pull request includes the changes for upgrading to Laravel 6.0. Feel free to commit any additional changes to the
shift-17748
branch.Before merging, you should:
shift-17748
branchcomposer update
(if the scripts fail, add--no-scripts
)If you want help with your upgrade, check out the Shift Human Services or join the Shifty Coders Slack room to get answers to all your Laravel questions.