Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 6.0 Shift #151

Merged
merged 6 commits into from
Sep 4, 2019
Merged

Laravel 6.0 Shift #151

merged 6 commits into from
Sep 4, 2019

Conversation

freekmurze
Copy link
Member

This pull request includes the changes for upgrading to Laravel 6.0. Feel free to commit any additional changes to the shift-17748 branch.

Before merging, you should:

  • Checkout the shift-17748 branch
  • Review all pull request comments for additional changes
  • Update your dependencies for Laravel 6.0
  • Run composer update (if the scripts fail, add --no-scripts)
  • Thoroughly test your application (no tests?)

If you want help with your upgrade, check out the Shift Human Services or join the Shifty Coders Slack room to get answers to all your Laravel questions.

In an effort to make upgrading the constantly changing config files
easier, Shift defaulted them so you can review the commit diff for
changes. Moving forward, you should use ENV variables or create a
separate config file to allow the core config files to remain
automatically upgradeable.
@freekmurze
Copy link
Member Author

⚠️ Shift defaulted the following configuration files. This was done in the Default config files commit so you may easily review and backfill any of your customizations.

  • config/broadcasting.php
  • config/database.php
  • config/queue.php
  • config/services.php

@freekmurze
Copy link
Member Author

ℹ️ The Eloquent model's toArray() method will now cast any attributes that implement Illuminate\Contracts\Support\Arrayable to an array. While unlikely to impact your application, this change could effect code which relies upon the previous data type or output.

@freekmurze
Copy link
Member Author

ℹ️ Laravel 6.0 made performance optimizations for integer key types. If you are using a string as your model's primary key, you may set the $keyType property on your model.

/**
 * The "type" of the primary key ID.
 *
 * @var string
 */
protected $keyType = 'string';

@freekmurze
Copy link
Member Author

ℹ️ The mandrill and sparkpost mail drivers, as well as the rackspace storage driver were removed in Laravel 6.0. If you were using these drivers, you may adopt a community maintained package which provides the driver.

@freekmurze
Copy link
Member Author

ℹ️ Previous versions of Laravel would retry jobs indefinitely. Beginning with Laravel 6.0, the php artisan queue:work now tries a job one time by default. If you want to force jobs to be tried indefinitely, you may pass the --tries=0 option.

@freekmurze
Copy link
Member Author

ℹ️ Shift noticed you have additional namespaces in your application. You should consider using the Consolidate Namespaces Shift to simplify your namespaces into the default Laravel App namespace.

@freekmurze
Copy link
Member Author

⚗️ This Shift is still being refined. Please report any issues or suggestions. Your feedback is what helps improve the experience for everyone.

@freekmurze
Copy link
Member Author

🎉 Congratulations, you're now running the latest version of Laravel.

The following Shifts can ensure your app is fully upgraded and following the practices recommended by Laravel and the community:

  • Laravel Linter analyzes your codebase for potential opportunities to do things "The Laravel Way".
  • Laravel Fixer automates many of the suggestions found by the Linter and other Shifts.
  • Upgrade Checker ensures your application is fully upgraded by detecting any outdated code.

In addition, stay upgraded forever as well as run these Shifts by subscribing to one of the new Shifty Plans.

@@ -39,6 +39,7 @@ class Kernel extends HttpKernel
*/
protected $routeMiddleware = [
'auth' => \App\Http\Middleware\Authenticate::class,
\Illuminate\Routing\Middleware\ThrottleRequests::class,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the 'throttle' key is missing 👀 @jasonmccreary

Copy link

@jasonmccreary jasonmccreary Sep 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not exactly it, it actually belongs in the middleware priority. That's where it should have been added. I'll tweak the hooks to ensure it skips this part.

@freekmurze freekmurze merged commit 9b80e0d into master Sep 4, 2019
@freekmurze freekmurze deleted the shift-17748 branch September 4, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants