Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to Serializable Closure of laravel #172

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

Stevemoretz
Copy link
Contributor

As mentioned in https://github.com/laravel/serializable-closure

This project is a fork of the excellent opis/closure: 3.x package. At Laravel, we decided to fork this package as the upcoming version 4.x is a complete rewrite on top of the FFI extension. As Laravel is a web framework, and FFI is not enabled by default in web requests, this fork allows us to keep using the 3.x series while adding support for new PHP versions.

the version 4 will stop working, so it's better use this package which is maintained by laravel.

@freekmurze freekmurze merged commit a004d8f into spatie:master Feb 10, 2022
@freekmurze
Copy link
Member

Thanks!

@freekmurze
Copy link
Member

Seems like this PR broke the tests, could you take a look at that? Thanks!

@Stevemoretz
Copy link
Contributor Author

Seems like this PR broke the tests, could you take a look at that? Thanks!

No problem, sure let me check it out.

@Stevemoretz Stevemoretz mentioned this pull request Feb 10, 2022
@Stevemoretz
Copy link
Contributor Author

Seems like this PR broke the tests, could you take a look at that? Thanks!

Fixed this one at : #181
Also fixed the tests for :

#173 and #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants