Add Task support #12
Merged
Add Task support #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply fixes from StyleCI
Apply fixes from StyleCI
|
@freekmurze Could you take a look at this one? |
|
Sure! 👍
On Sun, 31 Dec 2017 at 10:08, Brent Roose ***@***.***> wrote:
@freekmurze <https://github.com/freekmurze> Could you take a look at this
one?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAdiDVBOQvEnoC_wUk-gaLCYC0c7EqYsks5tF08EgaJpZM4RMQ60>
.
--
Freek Van der Herten https://spatie.be +32 495 84 27 91
|
freekmurze
reviewed
Dec 31, 2017
README.md
Outdated
| @@ -29,7 +29,7 @@ foreach ($things as $thing) { | |||
| // Do a thing | |||
| })->then(function ($output) { | |||
| // Handle success | |||
| })->catch(function (Exception $e) { | |||
| })->catch(function (Throwable $e) { | |||
There was a problem hiding this comment.
Very small nitpick: use $exception instead of $e
README.md
Outdated
| @@ -111,6 +111,34 @@ await($pool); | |||
| If an exception is thrown from within a child process, and not caught using the `->catch()` callback, | |||
| it will be thrown as `Spatie\Async\ParallelError` when calling `await()` or `$pool->wait()`. | |||
|
|
|||
| ### Working with tasks | |||
|
|
|||
| Besides using closures, you can also work with a Task. | |||
README.md
Outdated
| Besides using closures, you can also work with a Task. | ||
| A Task is useful in situations where you need more setup work in the child process. | ||
| Because a child process is always bootstrapped from nothing, | ||
| chances are you'll want to initialise eg. the dependency container before executing the task. |
There was a problem hiding this comment.
Why start on a newline here? Could it be that you don't have line wrapping configured in your editor?
There was a problem hiding this comment.
It's a habit I use for markdown files, because line wrapping in markdown files also enables it in PHP files, which I don't like. But I've added the changes.
| abstract public function execute(); | ||
|
|
||
| public function __invoke() |
There was a problem hiding this comment.
Pretty cool way to make executing a task the same as executing a callable ❤️
README.md
Outdated
| } | ||
|
|
||
| // Add the task to the pool | ||
| $pool[] = async(new MyTask()); |
There was a problem hiding this comment.
Replace that line by the more developer friendly:
$pool->add(new MyTask());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
Taskis another way of making a child process execute code, allowing for bootstrapping an application or parts of it. Eg. initialise the dependency container or load all config.