Code cleanup

spatie · Jan 2, 2018 · caac1e3 · caac1e3
1 parent f6bbb1a
commit caac1e3
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/src/PoolStatus.php b/src/PoolStatus.php
@@ -23,7 +23,7 @@ public function __toString(): string
 
     protected function lines(string ...$lines): string
     {
-        return implode("\n", $lines);
+        return implode(PHP_EOL, $lines);
     }
 
     protected function summaryToString(): string
@@ -39,20 +39,14 @@ protected function summaryToString(): string
 
     protected function failedToString(): string
     {
-        $failed = $this->pool->getFailed();
-
-        $status = '';
-
-        foreach ($failed as $process) {
+        return (string) array_reduce($this->pool->getFailed(), function ($currentStatus, ParallelProcess $process) {
             $output = $process->getErrorOutput();
 
             if ($output instanceof SerializableException) {
                 $output = get_class($output->asThrowable()).': '.$output->asThrowable()->getMessage();
             }
 
-            $status = $this->lines($status, "{$process->getPid()} failed with {$output}");
-        }
-
-        return $status;
+            return $this->lines((string) $currentStatus, "{$process->getPid()} failed with {$output}");
+        });
     }
 }