Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a busy_handler_timeout setter #443

Merged
merged 12 commits into from
Jan 3, 2024
Merged

Add a busy_handler_timeout setter #443

merged 12 commits into from
Jan 3, 2024

Commits on Dec 29, 2023

  1. Add a lock_wait_timeout setter to set a busy_handler that releases th… 

    …e GVL between connection retries, but also errors after the timeout passes
    @fractaledmind
    fractaledmind committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    b05600e View commit details
    Browse the repository at this point in the history

  2. Rename to busy_handler_timeout

    @fractaledmind
    fractaledmind committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    0b2ff58 View commit details
    Browse the repository at this point in the history

  3. Update test_integration_pending.rb

    @fractaledmind
    fractaledmind committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    ec687cf View commit details
    Browse the repository at this point in the history

  4. Simplify the busy_handler_timeout 

    Don't use a modulo and pre-compute the timeout_deadline
    @fractaledmind
    fractaledmind committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    6ef4db2 View commit details
    Browse the repository at this point in the history

  5. Update database.rb

    @fractaledmind
    fractaledmind committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    17c9db8 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2024

  1. Write better tests of the busy_handler_timeout

    @fractaledmind
    fractaledmind committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    e84b777 View commit details
    Browse the repository at this point in the history

  2. Make the tests more expressive to make failures (why) easier to debug… 

    … (hopefully)
    @fractaledmind
    fractaledmind committed Jan 1, 2024
    Configuration menu
    Copy the full SHA
    a8d1715 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Try to create a more resilient test for the busy_handler_timeout

    @fractaledmind
    fractaledmind committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    77906c4 View commit details
    Browse the repository at this point in the history

  2. Add additional assertion to ensure that timings are within a range

    @fractaledmind
    fractaledmind committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    59ecd77 View commit details
    Browse the repository at this point in the history

  3. Make test directly compare time using busy_timeout vs busy_handler_ti… 

    …meout
    @fractaledmind
    fractaledmind committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    9444b9b View commit details
    Browse the repository at this point in the history

  4. Fix bug with busy_handler_timeout and write better tests

    @fractaledmind
    fractaledmind committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    48daae1 View commit details
    Browse the repository at this point in the history

  5. Ensure that db connections are closed

    @fractaledmind
    fractaledmind committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    0c93d30 View commit details
    Browse the repository at this point in the history