-
-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Parse options doc #3360
[DOC] Parse options doc #3360
Conversation
Thank you for opening this! I apologize for not having made time to review this yet. I will do so in the next few days! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took so long to circle back on this PR. Thank you so much for the time you've invested!
9731e5e
to
00fd1e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I rebased onto origin/main and made a few small whitespace changes to please rubocop and make sure it's indented consistently.
Thank you so much, @BurdetteLamar! |
@flavorjones Some additional notes from me:
|
@nwellnhof Thanks for the additional notes, either @BurdetteLamar or I will circle back on these docs and make some more changes. Do you know offhand when HUGE became safe to enable? I'd like to enable it by default if Nokogiri is built with an appropriate version of libxml2. |
I'd say since CVE-2022-40303 was fixed, so 2.10 and later should be safe. The fix was backported to several older distros as well. |
I also finalized the design of new options for 2.14, so I simply leave this here:
|
What problem is this PR intended to solve?
Improvements to doc for XML::ParseOptions.
Have you included adequate test coverage?
N/A. All doc.
Does this change affect the behavior of either the C or the Java implementations?
No.