dep: update minimum supported version of libxml to 2.7.7 #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All supported libxml2 versions have these functions.
which has been handled since libxml 2.7.7
only broken in the 2.6.x series
fixed in libxml 2.7.7
flavorjones
added a commit
that referenced
this pull request
Jun 20, 2024
flavorjones
added a commit
that referenced
this pull request
Aug 7, 2024
I'm deciding to drop support for earlier versions because: - 2.7.7 nanohttp.c doesn't compile on modern systems - 2.8.0 doesn't have PARSE_BIG_LINES, GNOME/libxml2@968a03a2 introduced it in 2.9.0 - 2.9.0 and 2.9.1 have the xpath optimization bug that ruined our CSS queries in :first-child broken with libxml 2.9.0 #829, GNOME/libxml2@b4bcba23 fixed it in 2.9.2 Also, bump the min recommended version to v2.12.0 because Nick has fixed a lot of long-standing issues upstream. ♥ ♥ ♥ Followup to #3232 Closes #3287
flavorjones
added a commit
that referenced
this pull request
Aug 7, 2024
**What problem is this PR intended to solve?** I'm deciding to drop support for earlier versions because: - 2.7.7 nanohttp.c doesn't compile on modern systems - 2.8.0 doesn't have PARSE_BIG_LINES, GNOME/libxml2@968a03a2 introduced it in 2.9.0 - 2.9.0 and 2.9.1 have the xpath optimization bug that ruined our CSS queries in :first-child broken with libxml 2.9.0 #829, GNOME/libxml2@b4bcba23 fixed it in 2.9.2 Also, bump the min recommended version to v2.12.0 because Nick has fixed a lot of long-standing issues upstream. ♥ ♥ ♥ Followup to #3232 Closes #3287 **Have you included adequate test coverage?** Existing coverage is sufficient. **Does this change affect the behavior of either the C or the Java implementations?** No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
We have some code that exists to workaround old versions of libxml, and I want to get rid of it. v2.7.7 is a convenient version that lets us get rid of most of the C workarounds and is also 14 years old so I hope to hell nobody is still running it.
We could probably choose a later version, but it wouldn't simplify the code much. I'm fine waiting for a compelling reason to do so.
I've also removed some tests/assertions that were conditional on now-unsupported versions of libxml2.
Have you included adequate test coverage?
N/A
Does this change affect the behavior of either the C or the Java implementations?
N/A