improve documentation for CSS.xpath_for, and reorganize css tests #3224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that I can run them all with `-n/Nokogiri::CSS/` while I'm developing the SyntaxTree integration.
Note that the docs previously incorrectly stated the return value type as String, when it's actually an Array<String>. Also added examples and linked out to other sections for more information on supported CSS syntax and advanced features.
flavorjones
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
test/cssand all named something that starts withNokogiri::CSS, which should make it easier to isolate and run them as we improve the parser.CSS.xpath_forsince this is the sole entry point into the CSS parser for advanced users.Have you included adequate test coverage?
N/A
Does this change affect the behavior of either the C or the Java implementations?
N/A