dep: update minimum java version from 7 to 8 #3134
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modern OpenJDK (e.g., 21) won't build for Java 7 making development hard - JRuby 9.4 only supports Java 8 and later, and Nokogiri only supports JRuby 9.4+ - Java 7 extended support finally ended in July 2022 - https://support.oracle.com/knowledge/Middleware/2809708_1.html See related commit 08e5560 which updated the minimum to 7 from 6 in 2020 (v1.11.0).
|
Totally ok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
See related commit 08e5560 which updated the minimum to 7 from 6 in 2020 (v1.11.0).
cc @headius for review
Have you included adequate test coverage?
Non-functional change.
Does this change affect the behavior of either the C or the Java implementations?
Non-functional change.