wip - migrate to oedipus_lex #2934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-migrate-to-oedipus-lex
branch
from
2d263e0 to
b94eda0
Compare
see prior work at #1337
flavorjones
force-pushed
the
flavorjones-migrate-to-oedipus-lex
branch
from
b94eda0 to
c1f733e
Compare
zenspider
force-pushed
the
flavorjones-migrate-to-oedipus-lex
branch
4 times, most recently
from
d5fb727 to
0df0396
Compare
zenspider
force-pushed
the
flavorjones-migrate-to-oedipus-lex
branch
from
0df0396 to
4949437
Compare
|
All greened up. DO NOT MERGE AS IS... I added a |
|
@zenspider Thanks for your work on this. I'm back from vacation and will make time to take a look in the next few days. |
|
no rush! |
|
I'm going to be moving Nokogiri to a hand-written tokenizer and parser for the CSS selectors. See #2560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
@zenspider is making the case that oedipus_lex is better, faster, and better supported than rexical. Let's try it (again).
See prior work at #1337
To reproduce the failing test: run
bundle exec rake css:clean css:generate