Clear cached XPathContext after attribute change or node removal #1056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In following up on #1034 and trying to fix a bunch of failing tests in projecthydra/om under JRuby, I discovered some XPath queries returning incorrect nodesets. It turned out that while the cached XPathContext was being cleared after certain node manipulations, it wasn't being properly cleared after attribute modifications or node removal.
Both of the added tests fail on the current master and pass with these changes.