Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform Gatekeeper scan and still use new temp directory for installs #2433

Closed
wants to merge 1 commit into from

Conversation

zorgiepoo
Copy link
Member

This restores using a new temporary directory before swapping the app update (when the bundles are on the same volume). It turns out it is still a good idea to have this. This also seems to allow doing the gatekeeper scan without any issues on macOS Sonoma.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested updating notarized app
Tested updating unsigned app
Tested updating app on different volume (USB drive)

macOS version tested: 14.0 Beta (23A5337a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant