Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence deprecations and use modern NSSecureCoding APIs #2058

Merged
merged 5 commits into from
Jan 10, 2022

Conversation

zorgiepoo
Copy link
Member

Suppress few deprecation warnings (that would show up when increasing deployment target) and use newer APIs when available.

Misc Checklist:

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested secure coding is still enforced, tested Sparkle Test App works, plus testing in CI.

macOS version tested: 12.1 (21C52)

@zorgiepoo zorgiepoo merged commit b05c058 into 2.x Jan 10, 2022
@zorgiepoo zorgiepoo deleted the silence-deprecations branch January 10, 2022 03:25
@zorgiepoo zorgiepoo changed the title Silence deprecations Silence deprecations and use modern NSSecureCoding APIs Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant