Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version History opens full release notes (changelog) if informed #2001

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

aonez
Copy link
Contributor

@aonez aonez commented Nov 4, 2021

Addition to #1877 & #1989.

If informed in the appcast item, fullReleaseNotesLink will be used as the Version History (#1877) action instead of releaseNotesLink.
It will only be used if the delegate standardUserDriverShowVersionHistoryForAppcastItem (#1989) is not implemented.

  • Lacks Tests because I'm not sure of the need in this specific case.
  • Lacks generate_appcast code yet. Since this is a link that will open in the default browser I'm not sure it needs localization. Usually websites already detect the preferred language and show the appropriate content.

Checklist:

  • My change is being tested and reviewed against the Sparkle 2.x branch. New changes must be developed on the 2.x development branch first.
  • My change is being backported to master branch (Sparkle 1.x). Please create a separate pull request for 1.x, should it be backported. Note 1.x is feature frozen and is only taking bug fixes, localization updates, and critical OS adoption enhancements.
  • I have reviewed and commented my code, particularly in hard-to-understand areas.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • My change is or requires a documentation or localization update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

macOS version tested: 11.6.1 (20G224)

Addition to sparkle-project#1877
Lacks Tests & generate_appcast code
@aonez
Copy link
Contributor Author

aonez commented Nov 4, 2021

As stated:

Lacks generate_appcast code yet. Since this is a link that will open in the default browser I'm not sure it needs localization. Usually websites already detect the preferred language and show the appropriate content.

Since I'm not sure how to proceed there, I prefer to wait and discuss or leave it to others to finish that part.

@aonez aonez changed the title fullReleaseNotesLink implemented Version History opens full release notes (changelog) if informed Nov 4, 2021
@zorgiepoo
Copy link
Member

This looks good, thanks! I may make some minor post documentation edits later.

Lacks Tests because I'm not sure of the need in this specific case.

I wouldn't worry about this.

Lacks generate_appcast code yet. Since this is a link that will open in the default browser I'm not sure it needs localization. Usually websites already detect the preferred language and show the appropriate content.

This sounds good to expect that fullReleaseNotesURL should probably not be localizable. I'm satisfied with that.

@zorgiepoo zorgiepoo merged commit 4c1bebe into sparkle-project:2.x Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants