Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds standard user driver delegate method for responding to Version History button #1989

Merged
merged 6 commits into from
Oct 29, 2021
Merged

Adds standard user driver delegate method for responding to Version History button #1989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c10bf8f
Updates Version History French string translation.
R4N Oct 11, 2021
5699e46
Adds standard user driver delegate for providing a custom response to…
billymeltdown Oct 29, 2021
4326fe6
Merge branch '2.x' of https://github.com/billymeltdown/Sparkle into 2.x
billymeltdown Oct 29, 2021
246f263
For PR #1989 (Version History delegate call) Removes unneeded weak re…
billymeltdown Oct 29, 2021
c0e9eab
For PR #1989; Renames Version History delegate method to standardUser…
billymeltdown Oct 29, 2021
0726933
For PR #1989, goofed and forgot to adjust the respondsToSelector chec…
billymeltdown Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions Sparkle/SPUStandardUserDriver.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,21 @@ - (void)showUpdateNotFoundWithError:(NSError *)error acknowledgement:(void (^)(v
switch (reason) {
case SPUNoUpdateFoundReasonOnLatestVersion:
case SPUNoUpdateFoundReasonOnNewerThanLatestVersion: {
if (latestAppcastItem.releaseNotesURL != nil) {
// Show the user the past version history if available
[alert addButtonWithTitle:SULocalizedString(@"Version History", nil)];
// Show the user the past version history if available
NSString *localizedButtonTitle = SULocalizedString(@"Version History", nil);

// Check if the delegate implements a Version History action
id <SPUStandardUserDriverDelegate> delegate = self.delegate;

if ([delegate respondsToSelector:@selector(standardUserDriverShowVersionHistoryForAppcastItem:)]) {
[alert addButtonWithTitle:localizedButtonTitle];

secondaryAction = ^{
[delegate standardUserDriverShowVersionHistoryForAppcastItem:latestAppcastItem];
};
} else if (latestAppcastItem.releaseNotesURL != nil) {
// Fall back to opening the release notes URL (or forthcoming full version history link attr!)
[alert addButtonWithTitle:localizedButtonTitle];

secondaryAction = ^{
[[NSWorkspace sharedWorkspace] openURL:(NSURL * _Nonnull)latestAppcastItem.releaseNotesURL];
Expand Down
9 changes: 9 additions & 0 deletions Sparkle/SPUStandardUserDriverDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,13 @@ SU_EXPORT @protocol SPUStandardUserDriverDelegate <NSObject>
*/
- (_Nullable id <SUVersionDisplay>)standardUserDriverRequestsVersionDisplayer;

/**
Called if implemented when the Version History button is chosen by the user. Otherwise,
the `fullReleaseNotesLink` or `releaseNotesLink` in the appcast's latest item will be be
opened.

@param item The appcast item corresponding to the latest version available.
*/
- (void)standardUserDriverShowVersionHistoryForAppcastItem:(SUAppcastItem *_Nonnull)item;

@end