fix: some iframes can use about:srcdoc, which spawns popups (follow-up to #1586)

[lwouis]

Hi,

This is follow-up to #1586

It turns out some iframes use about:srcdoc instead of about:blank, and this creates the same issue as in the original PR.

This PR is a one-liner, so I hope you forgive if I didn't fill the template

Thank you!

[zorgiepoo]

@kornelski do you want to review over this one? I think the change is probably fine on its own, but I'm little weary about our safe URL handling logic, and I'm not sure if there are other HTML / iframe cases we're missing.

• We also need a PR for 2.x branch for changes to land in the project.

[zorgiepoo]

If you can, you may also want to test the change with the legacy webkit 1 implementation for older OS's (or apps without sandboxed network entitlement), by temporarily adjusting the code so it takes the path of using [[SULegacyWebView alloc] init...]

[kornelski]

Sorry, I don't have time to be involved in the project.

[zorgiepoo]

Ok thanks for response.

So two things here.

1. Create a PR for 2.x branch (and test it there)
2. Test legacy webview implementation

Then I'll want to just look up a bit more on about:srcdoc and implications in the codebase here.

[zorgiepoo]

I am dealing this with in #2006 and #2007 (made a minor change to avoid nullability issue). Thanks for bringing this up. Fyi, tagged pre-releases are published to Cocoapods now (will get the chance to publish a pre-release shortly).