Don't bring up authorization just because group ID doesn't match #1830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't bring up authorization just because group ID doesn't match
Let us not bother the user in the more unusual case the group can't be changed. I think this is the right thing to do for most apps.. Apps that want auth should be owned by root user, Sparkle tools like BinaryDelta also don't support weird permission modes like 0770 last I recall.
This change is not back-portable to 1.x (see below).
Fixes #1108
Checklist:
Type of change
Testing
I tested and verified my change by using one or multiple of these methods:
With Sparkle Test App, tested:
Regular app update with user:staff (no auth)
App update that is root:wheel (auth)
App update that is user:wheel (no auth)
App update whose parent directory is root:wheel (auth)
macOS version tested: 11.2.3 (20D91)