Add quicker & more reliable updating to features #1802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add quicker & more reliable updating to features.
Sparkle 2 is perceivably faster at relaunching an application (it saves an extra process spawn / app launch cycle because the installer is already running at the point the user wants to relaunch). 1.x branch seems to not validate the update async as well, delaying the start of installation. 2.x also doesn't show status window if the install is instant.
Sample attached using VLC:
https://user-images.githubusercontent.com/857267/111960741-5bdb3500-8aad-11eb-84ef-36a1a74494e9.mov
Two points: look at how fast old app disappears and new app appears animated in Dock, and look at how fast app terminates when Install and Relaunch is clicked / activated.
The auth execution model in 1.x using fileop is just built off of sticks and stones to me regarding reliability, and was replaced by a more robust architecture of deciding to run the installer (Autoupdate) as root or not (and not shelling out with
AuthorizationExecuteWithPrivileges
)