Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression limit upped from 50 to 75 #41

Merged
merged 1 commit into from
Jul 6, 2016
+8 −4
Merged

Expression limit upped from 50 to 75 #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
v1.0.3, 2016-06-06 ([changes](https://github.com/sparkapi/sparkql/compare/v1.0.2...v1.0.3))
-------------------
* [IMPROVEMENT] Expression limit lifted to 75 expressions

v1.0.2, 2016-04-26 ([changes](https://github.com/sparkapi/sparkql/compare/v1.0.1...v1.0.2))
-------------------
* [IMPROVEMENT] Support for new range() function for character ranges
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.0.2
1.0.3
2 changes: 1 addition & 1 deletion lib/sparkql/parser_compatibility.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
module Sparkql::ParserCompatibility

MAXIMUM_MULTIPLE_VALUES = 200
MAXIMUM_EXPRESSIONS = 50
MAXIMUM_EXPRESSIONS = 75
MAXIMUM_LEVEL_DEPTH = 2

# TODO I Really don't think this is required anymore
Expand Down
4 changes: 2 additions & 2 deletions test/unit/parser_compatability_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,11 +338,11 @@ def find_operator(string)
test "max out expressions" do
parser = Parser.new
to_the_max = []
60.times do |x|
80.times do |x|
to_the_max << "City Eq 'Fargo'"
end
vals = parser.tokenize(to_the_max.join(" And "))
assert_equal 50, vals.size
assert_equal 75, vals.size
assert parser.errors?
end

Expand Down