Skip to content

Commit

Permalink
ARMLS-2577 Expression limit upped from 50 to 75
Browse files Browse the repository at this point in the history
  • Loading branch information
Joshua Murray committed Jul 6, 2016
1 parent 403b91b commit f47abe9
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
v1.0.3, 2016-06-06 ([changes](https://github.com/sparkapi/sparkql/compare/v1.0.2...v1.0.3))
-------------------
* [IMPROVEMENT] Expression limit lifted to 75 expressions

v1.0.2, 2016-04-26 ([changes](https://github.com/sparkapi/sparkql/compare/v1.0.1...v1.0.2))
-------------------
* [IMPROVEMENT] Support for new range() function for character ranges
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.0.2
1.0.3
2 changes: 1 addition & 1 deletion lib/sparkql/parser_compatibility.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
module Sparkql::ParserCompatibility

MAXIMUM_MULTIPLE_VALUES = 200
MAXIMUM_EXPRESSIONS = 50
MAXIMUM_EXPRESSIONS = 75
MAXIMUM_LEVEL_DEPTH = 2

# TODO I Really don't think this is required anymore
Expand Down
4 changes: 2 additions & 2 deletions test/unit/parser_compatability_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -338,11 +338,11 @@ def find_operator(string)
test "max out expressions" do
parser = Parser.new
to_the_max = []
60.times do |x|
80.times do |x|
to_the_max << "City Eq 'Fargo'"
end
vals = parser.tokenize(to_the_max.join(" And "))
assert_equal 50, vals.size
assert_equal 75, vals.size
assert parser.errors?
end

Expand Down

0 comments on commit f47abe9

Please sign in to comment.