Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the default port with 8080 #352

Merged
merged 4 commits into from
Jan 21, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: replace port 5051 -> 8081 for consistency
  • Loading branch information
sansyrox committed Jan 21, 2023
commit d4b0c30947aa903f9831aa6fded99bd3949f8f0f
2 changes: 1 addition & 1 deletion integration_tests/conftest.py
Original file line number Diff line number Diff line change
@@ -70,7 +70,7 @@ def global_session():
@pytest.fixture(scope="session")
def dev_session():
os.environ["ROBYN_URL"] = "127.0.0.1"
os.environ["ROBYN_PORT"] = "5001"
os.environ["ROBYN_PORT"] = "8081"
current_file_path = pathlib.Path(__file__).parent.resolve()
base_routes = os.path.join(current_file_path, "./base_routes.py")
command = ["python3", base_routes, "--dev"]
5 changes: 2 additions & 3 deletions integration_tests/test_base_url.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import os

import requests


@@ -24,7 +23,7 @@ def test_global_index_request(global_session):


def test_dev_index_request(dev_session):
BASE_URL = "http://127.0.0.1:5001"
BASE_URL = "http://127.0.0.1:8081"
res = requests.get(f"{BASE_URL}")
assert os.getenv("ROBYN_PORT") == "5001"
assert os.getenv("ROBYN_PORT") == "8081"
assert res.status_code == 200
2 changes: 1 addition & 1 deletion robyn/robyn.pyi
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ class Response:
headers: dict[str, str]
body: str

def set_file_path(file_path):
def set_file_path(self, file_path: str):
pass