Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The --dev flag not working on Windows #283

Closed
sansyrox opened this issue Sep 15, 2022 · 8 comments
Closed

[BUG] The --dev flag not working on Windows #283

sansyrox opened this issue Sep 15, 2022 · 8 comments

Comments

@sansyrox
Copy link
Member

sansyrox commented Sep 15, 2022

Description

--dev flag not working on windows

Traceback (most recent call last): File "C:\Users\Gaurav Bhattacharjee\OneDrive\Desktop\Projects\rob\robyn\integration_tests\base_routes.py", line 209, in <module> app.start(port=ROBYN_PORT, url=ROBYN_URL) File "\\?\C:\Users\Gaurav Bhattacharjee\OneDrive\Desktop\Projects\rob\robyn\robyn\__init__.py", line 163, in start event_handler.start_server_first_time() File "\\?\C:\Users\Gaurav Bhattacharjee\OneDrive\Desktop\Projects\rob\robyn\robyn\dev_event_handler.py", line 14, in start_server_first_time self.processes.append(subprocess.Popen(["python3", self.file_name], start_new_session=False)) File "C:\Users\Gaurav Bhattacharjee\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 969, in __init__ self._execute_child(args, executable, preexec_fn, close_fds, File "C:\Users\Gaurav Bhattacharjee\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 1438, in _execute_child hp, ht, pid, tid = _winapi.CreateProcess(executable, args, FileNotFoundError: [WinError 2] The system cannot find the file specified

To replicate this issue: pytest -s integration_tests . You will see two tests failing.

Expected Behavior

The tests should not fail. 😄

Screenshots

Environment:

  • Host OS: Windows

[Optional] Additional Context


@guilefoylegaurav
Copy link
Contributor

Hey @sansyrox I am interested in taking this up :) Will look into this issue soon

@sansyrox
Copy link
Member Author

Thanks @guilefoylegaurav . Let me know if you require any suport/information from my end 😄

@guilefoylegaurav
Copy link
Contributor

@sansyrox I am sorry, could not update you on this - stuck with mid-terms for 4 days. Shall get back to this soon.

@sansyrox
Copy link
Member Author

Hi @guilefoylegaurav ,
No worries. Take your time 😄

Also, all the best with your mid-terms! ✨

guilefoylegaurav added a commit to guilefoylegaurav/robyn that referenced this issue Oct 7, 2022
* fix(dev_event_handler.py): use platform specific python3 alias to spawn processes
guilefoylegaurav added a commit to guilefoylegaurav/robyn that referenced this issue Oct 8, 2022
* fix(dev_event_handler.py): use platform specific python3 alias to spawn processes
guilefoylegaurav added a commit to guilefoylegaurav/robyn that referenced this issue Oct 12, 2022
* fix(dev_event_handler.py): use platform specific python3 alias to spawn processes
guilefoylegaurav added a commit to guilefoylegaurav/robyn that referenced this issue Oct 12, 2022
* fix(dev_event_handler.py): use platform specific python3 alias to spawn processes
guilefoylegaurav added a commit to guilefoylegaurav/robyn that referenced this issue Oct 15, 2022
* fix(dev_event_handler.py): use platform specific python3 alias to spawn processes
sansyrox pushed a commit that referenced this issue Oct 17, 2022
* fix(dev_event_handler.py): use platform specific python3 alias to spawn processes
Shending-Help pushed a commit to Shending-Help/robyn that referenced this issue Oct 19, 2022
* fix(dev_event_handler.py): use platform specific python3 alias to spawn processes
@guilefoylegaurav
Copy link
Contributor

guilefoylegaurav commented Oct 27, 2022

@sansyrox with reference to the problem of hot reload mode not reflecting instant changes in (some, including mine) windows/linux machines, did you look into this?

Hi @guilefoylegaurav , thanks for your PR.

I don't have an access to a windows machine till the 26th so can't really tell you about the windows issue.

Dev server reflects the right changes on my osx machine but is not killed properly on KeyboardInterrupt. I will check my linux PC to give you updates about the debian state.

If the same problem persists, feel free to let me know, I shall investigate and explore further.

@sansyrox
Copy link
Member Author

@guilefoylegaurav , I didn't get a chance to have a look at it yet. Would you like have a look at it?

@guilefoylegaurav
Copy link
Contributor

Sure

@sansyrox
Copy link
Member Author

It works now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants