Fix compilation errors with Clang v16+. Also includes fixes for compiling with -std=c++23. #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compiling with -std=c++23.
bdutro
commented
Apr 30, 2024
| @@ -187,7 +187,7 @@ namespace sparta::pipeViewer | |||
| if(!dat.stringVector[i].empty()){ | |||
| // We check if we have seen this exact pair, field and value before or not. | |||
| if(const auto& [val, str] = std::tie(dat.valueVector[i].first, dat.stringVector[i]); | |||
| stringMap.try_emplace(std::make_tuple(dat.pairId, i, val), str).second) { | |||
| stringMap.emplace(std::piecewise_construct, std::forward_as_tuple(dat.pairId, i, val), std::forward_as_tuple(str)).second) { | |||
There was a problem hiding this comment.
Workaround for a Clang bug: llvm/llvm-project#61415
This is essentially what try_emplace does under the hood, so performance shouldn't be affected.
bdutro
commented
Apr 30, 2024
| @@ -95,7 +95,7 @@ namespace sparta | |||
| */ | |||
| struct DataPointer { | |||
| private: | |||
| typename std::aligned_storage<sizeof(value_type), alignof(value_type)>::type object_memory_; | |||
| alignas(value_type) std::byte object_memory_[sizeof(value_type)]; | |||
There was a problem hiding this comment.
std::aligned_storage was deprecated in C++23: https://stackoverflow.com/questions/71828288/why-is-stdaligned-storage-to-be-deprecated-in-c23-and-what-to-use-instead
bdutro
commented
Apr 30, 2024
| @@ -27,56 +27,56 @@ | |||
| /*! | |||
| * \brief Custom literal for uint64 | |||
| */ | |||
| constexpr inline uint64_t operator "" _u64(unsigned long long i) { | |||
| constexpr inline uint64_t operator ""_u64(unsigned long long i) { | |||
There was a problem hiding this comment.
Clang throws a compiler error if there is a space between the "" and the _
bdutro
commented
Apr 30, 2024
Comment on lines
+199
to
+207
| ArchiveNode::ArchiveNode(const std::string & name) : | ||
| name_(name) | ||
| { | ||
| } | ||
|
|
||
| ArchiveNode::~ArchiveNode() | ||
| { | ||
| } | ||
|
|
There was a problem hiding this comment.
Moving these to the .cpp file helps avoid some pitfalls when you use an incomplete type with a smart pointer.
klingaard
reviewed
May 1, 2024
klingaard
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes compilation errors I observed trying to compile with clang v16 and v17, as well as some errors from bumping the C++ standard to C++23.