Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config sample for synapse admin with traefik 2 #607

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Added config sample for synapse admin with traefik 2 #607

merged 3 commits into from
Jul 27, 2020

Conversation

matthiasjo
Copy link
Contributor

I used the config sample at https://github.com/spantaleev/matrix-docker-ansible-deploy/blob/master/docs/configuring-playbook-own-webserver.md and extended it for the new synapse admin container, so that it would be available at https://matrix.DOMAIN/synapse-admin.
Please review and edit this PR.

Copy link
Owner

@spantaleev spantaleev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to the documentation!

I've submitted some feedback and questions :)

@@ -6,7 +6,6 @@ It's a web UI tool you can use to **administrate users and rooms on your Matrix

See the project's [documentation](https://github.com/Awesome-Technologies/synapse-admin) to learn what it does and why it might be useful to you.


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you restore this and the other removed lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry. the lines are restored

- '--label "traefik.enable=true"'

# The Synapse Admin container will only receive traffic from this subdomain and path
- '--label "traefik.http.routers.matrix-synapse-admin.rule=(Host(`{{ matrix_server_fqn_matrix }}`) && Path(`{matrix_synapse_admin_public_endpoint}`))"'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe {matrix_synapse_admin_public_endpoint} needs to be {{ matrix_synapse_admin_public_endpoint }}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're correct. changed it :)

docs/configuring-playbook-synapse-admin.md Outdated Show resolved Hide resolved
@spantaleev spantaleev merged commit 196eb2d into spantaleev:master Jul 27, 2020
@spantaleev
Copy link
Owner

Thank you! 👍

@matthiasjo matthiasjo deleted the docs_traefik_synapse_admin branch July 27, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants