[config] throw if config file has a syntax error (elastic#65)

spalger · Feb 5, 2018 · c235894 · c235894
1 parent 37fa96f
commit c235894
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/packages/kbn-plugin-helpers/lib/config_file.js b/packages/kbn-plugin-helpers/lib/config_file.js
@@ -19,13 +19,16 @@ module.exports = function (root) {
       const content = JSON.parse(readFileSync(resolve(root, configFile)));
       config = Object.assign(config, content);
     } catch (e) {
-      // noop
+      // rethrow error unless it's complaining about file not existing
+      if (e.code !== 'ENOENT') {
+        throw e;
+      }
     }
   });
 
   const deprecationMsg = 'has been removed from `@elastic/plugin-helpers`. ' +
     'During development your plugin must be located in `../kibana-extra/{pluginName}` ' +
-    'relative to the Kibana directory to work with this package.\n'
+    'relative to the Kibana directory to work with this package.\n';
 
   if (config.kibanaRoot) {
     throw new Error(