Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adios2: correct c-blosc dependency #39385

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

vicentebolea
Copy link
Member

@vicentebolea vicentebolea commented Aug 10, 2023

ADIOS2 2.9.0 changed dependency from c-blocs -> c-blosc2.

@vicentebolea
Copy link
Member Author

ornladios/ADIOS2#3715

@vicentebolea
Copy link
Member Author

@ax3l it appears that cblosc2 does not build in the openapi spec as shown here: https://gitlab.spack.io/spack/spack/-/jobs/7957954

I added the conflict in the c-blosc2 spec, let me know

@eugeneswalker
Copy link
Contributor

Thanks for updating this. Can we merge this today?

@ax3l
Copy link
Member

ax3l commented Aug 19, 2023

C-Blosc2 v.2.10.2 coming via #39537

Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What is the issue with oneapi and C-Blosc2?

@ax3l
Copy link
Member

ax3l commented Aug 19, 2023

C-Blosc issues w/ OneAPI compilers: Blosc/c-blosc2#546

Looks like a compiler flag to activate SSE3 is missing. Does Spack add -msse3?

@vicentebolea
Copy link
Member Author

@ax3l Thanks for following up with this issue, I guess that it is good to add this conflict() to the c-blosc2 pkg so that other user do not run into this issues (until it gets resolved)

Copy link
Contributor

@bernhardkaindl bernhardkaindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, until someone can test with -msse3 added, it may be better to add this conflict for %oneapi

@eugeneswalker eugeneswalker merged commit e01b9b3 into spack:develop Aug 23, 2023
11 checks passed
@vicentebolea vicentebolea deleted the fix-adios2-blocs2-dep branch August 23, 2023 21:44
mpokorny pushed a commit to mpokorny/spack that referenced this pull request Sep 18, 2023
* adios2: correct c-blosc dependency

* c-blosc2: disable oneapi spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants