-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adios2: correct c-blosc dependency #39385
adios2: correct c-blosc dependency #39385
Conversation
91c7fbb
to
42c92aa
Compare
@ax3l it appears that cblosc2 does not build in the openapi spec as shown here: https://gitlab.spack.io/spack/spack/-/jobs/7957954 I added the conflict in the c-blosc2 spec, let me know |
Thanks for updating this. Can we merge this today? |
C-Blosc2 v.2.10.2 coming via #39537 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. What is the issue with oneapi and C-Blosc2?
C-Blosc issues w/ OneAPI compilers: Blosc/c-blosc2#546 Looks like a compiler flag to activate SSE3 is missing. Does Spack add |
@ax3l Thanks for following up with this issue, I guess that it is good to add this conflict() to the c-blosc2 pkg so that other user do not run into this issues (until it gets resolved) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, until someone can test with -msse3 added, it may be better to add this conflict for %oneapi
* adios2: correct c-blosc dependency * c-blosc2: disable oneapi spec
ADIOS2 2.9.0 changed dependency from c-blocs -> c-blosc2.